stratum-apps::monitoring::server::{ServerExtendedChannelInfo,ServerStandardChannelInfo} displays SubmitShares.Error.error_code

[plebhash]

close #423

companion stratum-mining/stratum#2139

blocked by #462

---

the affected endpoint is GET /api/v1/server/channels

before, each channel would have:

"shares_rejected": 2

now, it gets:

"shares_rejected": {
  "duplicate-share": 1,
  "difficulty-too-low": 1
}

and if there's no rejected shares:

"shares_rejected": {}

[plebhash]

cc @gimballock

[plebhash]

btw I think if we merge this without a companion for stratum-mining/sv2-ui#93, then sv2-ui main branch might break, given that the HTTP endpoint response is changing

[Shourya742]

Suggested change

	let mut shares_rejected: HashMap<String, u32> = HashMap::new();
	let mut shares_rejected = HashMap::new();

[plebhash]

the other variables around it already set this pattern of explicit type declaration, so I don't think it makes sense to only remove this one.

[GitGab19]

Just a very minor thing, not a blocker.

LGTM.

[GitGab19]

We merged #462, so this is now unblocked.