Skip to content

Increase lowest supported version of Rust to 1.82 - #227

Merged
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-version-1.82.0
Dec 9, 2025
Merged

mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-version-1.82.0

Conversation

@mulkieran

@mulkieran mulkieran commented Dec 9, 2025 •

Copy link
Copy Markdown
Member

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Dec 9, 2025
@coderabbitai

coderabbitai Bot commented Dec 9, 2025 •

Copy link
Copy Markdown

Walkthrough

The minimum supported Rust version (MSRV) is raised from 1.77.0 to 1.82.0 across the CI workflow configuration and Cargo manifests for the root workspace and libblkid-rs-sys member.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/main.yml
Updated Rust toolchain version from 1.77.0 to 1.82.0 in three matrix entries (two macOS checks and one general checks block)
Cargo Manifests
Cargo.toml, libblkid-rs-sys/Cargo.toml
Bumped rust-version field from 1.77.0 to 1.82.0 in both the root and workspace member manifests

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

These are homogeneous, straightforward version updates with no logic or functional changes. All modifications follow the same pattern and require minimal verification.

Possibly related PRs

Poem

🐰 A hop, skip, and jump to Rust 1.82!
Our toolchain's fresh, our tests run true,
From 1.77's days, we've moved along,
With modern features, steady and strong! 🦀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main objective of the pull request—raising the minimum supported Rust version from 1.77.0 to 1.82.0 across all affected configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 118ce31 and ea6c376.

📒 Files selected for processing (3)
  • .github/workflows/main.yml (2 hunks)
  • Cargo.toml (1 hunks)
  • libblkid-rs-sys/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
🔇 Additional comments (3)
libblkid-rs-sys/Cargo.toml (1)

6-6: MSRV updated consistently with root workspace.

The rust-version is correctly bumped to 1.82.0, matching the root Cargo.toml and CI workflow settings.

.github/workflows/main.yml (1)

43-43: CI workflow properly covers MSRV across platforms.

All three MSRV matrix entries (general checks, macOS build, and macOS test) are correctly updated to 1.82.0. The configuration maintains distinct testing against both the MSRV (1.82.0) and current development toolchain (1.91.0) across Linux and macOS runners.

Also applies to: 76-76, 79-79

Cargo.toml (1)

6-6: Verify MSRV consistency across workspace members.

Rust 1.82.0 is a valid official stable release (October 17, 2024). However, confirm that all workspace Cargo.toml files (including libblkid-rs-sys and any others) have been updated to match this MSRV, and verify that CI workflows reference the correct toolchain version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran moved this to In Review in 2025December Dec 9, 2025
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-libblkid-rs-227
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran
mulkieran merged commit d27436e into stratis-storage:master Dec 9, 2025
20 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2025December Dec 9, 2025
@mulkieran
mulkieran deleted the rust-version-1.82.0 branch December 9, 2025 01:26
@mulkieran mulkieran moved this from Done to Done(1) in 2025December Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant