Repository navigation
Increase lowest supported version of Rust to 1.82 - #1013
Conversation
WalkthroughUpdates the minimum Rust toolchain version from 1.77.0 to 1.82.0 across CI workflow entries and two Cargo.toml manifests. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Signed-off-by: mulhern <amulhern@redhat.com>
25dc96d to
8831ae6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Cargo.toml (1)
26-26: Consider replacingonce_cellwithstd::sync::OnceLock.With Rust 1.82.0 as the new MSRV,
std::sync::OnceLock(stabilized in 1.70) is now available. This eliminates an external dependency and simplifies the dependency tree.If you decide to migrate, update the dependency removal and replace usages with the std lib equivalent:
-once_cell = "1.19.0"Then replace
once_cell::sync::Lazywithstd::sync::LazyLock(orOnceLockdepending on your usage pattern) throughout the codebase.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/main.yml(1 hunks)Cargo.toml(1 hunks)devicemapper-rs-sys/Cargo.toml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- devicemapper-rs-sys/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
🔇 Additional comments (1)
Cargo.toml (1)
13-13: Rust 1.82.0 MSRV bump is safe and well-supported by pinned dependencies.Verified: Rust 1.82.0 (released October 17, 2024) is compatible with all pinned dependencies. Key checks:
nix 0.30.1: MSRV = Rust 1.69+ ✓once_cell 1.19.0: MSRV = Rust 1.60+ ✓serde 1.0.60: No declared MSRV, but mature crate with no known incompatibilities ✓- Other pinned versions are compatible. No breaking changes between Rust 1.77.0 and 1.82.0 affect this codebase.
Optional: With Rust 1.82.0 MSRV, consider replacing the
once_celldependency withstd::sync::OnceLock(stabilized in Rust 1.70.0), which would reduce external dependencies.
Related stratis-storage/project#832