Skip to content

Increase lowest supported version of Rust to 1.82 - #1013

Merged
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-version-1.82.0
Dec 9, 2025
Merged

mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-version-1.82.0

Conversation

@mulkieran

@mulkieran mulkieran commented Dec 8, 2025 •

Copy link
Copy Markdown
Member

@mulkieran mulkieran self-assigned this Dec 8, 2025
@coderabbitai

coderabbitai Bot commented Dec 8, 2025 •

Copy link
Copy Markdown

Walkthrough

Updates the minimum Rust toolchain version from 1.77.0 to 1.82.0 across CI workflow entries and two Cargo.toml manifests.

Changes

Cohort / File(s) Summary
CI workflow
\.github/workflows/main\.yml
Updated Rust toolchain version entries in the GitHub Actions matrix from 1.77.0 to 1.82.0.
Root project manifest
Cargo\.toml
Bumped rust-version from 1.77.0 to 1.82.0.
Device-mapper sys crate manifest
devicemapper-rs-sys/Cargo\.toml
Bumped rust-version from 1.77.0 to 1.82.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous version bumps across CI and manifest files; no code or API changes.
  • Spot-check: .github/workflows/main.yml, Cargo.toml, and devicemapper-rs-sys/Cargo.toml.

Possibly related PRs

Poem

🐰 A tiny hop from seventy-seven to eighty-two,
Tools updated, builds refreshed and new,
CI sings, manifests align,
I nibble code and sip tea fine,
Hooray—our crate is fresh and true! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the minimum supported Rust version from 1.77.0 to 1.82.0 across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-devicemapper-rs-1013
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran moved this to In Review in 2025December Dec 8, 2025
@mulkieran mulkieran added this to the devicemapper-v0.34.6 milestone Dec 8, 2025
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
mulkieran force-pushed the rust-version-1.82.0 branch from 25dc96d to 8831ae6 Compare December 8, 2025 23:53

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Cargo.toml (1)

26-26: Consider replacing once_cell with std::sync::OnceLock.

With Rust 1.82.0 as the new MSRV, std::sync::OnceLock (stabilized in 1.70) is now available. This eliminates an external dependency and simplifies the dependency tree.

If you decide to migrate, update the dependency removal and replace usages with the std lib equivalent:

-once_cell = "1.19.0"

Then replace once_cell::sync::Lazy with std::sync::LazyLock (or OnceLock depending on your usage pattern) throughout the codebase.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25dc96d and 8831ae6.

📒 Files selected for processing (3)
  • .github/workflows/main.yml (1 hunks)
  • Cargo.toml (1 hunks)
  • devicemapper-rs-sys/Cargo.toml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • devicemapper-rs-sys/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
🔇 Additional comments (1)
Cargo.toml (1)

13-13: Rust 1.82.0 MSRV bump is safe and well-supported by pinned dependencies.

Verified: Rust 1.82.0 (released October 17, 2024) is compatible with all pinned dependencies. Key checks:

  • nix 0.30.1: MSRV = Rust 1.69+ ✓
  • once_cell 1.19.0: MSRV = Rust 1.60+ ✓
  • serde 1.0.60: No declared MSRV, but mature crate with no known incompatibilities ✓
  • Other pinned versions are compatible. No breaking changes between Rust 1.77.0 and 1.82.0 affect this codebase.

Optional: With Rust 1.82.0 MSRV, consider replacing the once_cell dependency with std::sync::OnceLock (stabilized in Rust 1.70.0), which would reduce external dependencies.

@mulkieran
mulkieran merged commit 3649845 into stratis-storage:master Dec 9, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2025December Dec 9, 2025
@mulkieran
mulkieran deleted the rust-version-1.82.0 branch December 9, 2025 01:31
@mulkieran mulkieran moved this from Done to Done(1) in 2025December Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant