fix(Core): complete bv128 literal support in FormatCore and Translate#1436
Open
kondylidou wants to merge 1 commit into
Open
fix(Core): complete bv128 literal support in FormatCore and Translate#1436kondylidou wants to merge 1 commit into
kondylidou wants to merge 1 commit into
Conversation
FormatCore's bitvec catch-all arm discarded the actual constant value and emitted bv64(128) for any 128-bit literal — wrong type and wrong value. Translate had no bv128Lit case, causing Core→DDM translation to fail for programs with 128-bit literals. Add explicit bv128 arms to both, mirroring the existing bv64 pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shigoel
added
the
CSLib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatCore's bitvec catch-all arm discarded the actual constant value and emitted bv64(128) for any 128-bit literal — wrong type and wrong value. Translate had no bv128Lit case, causing Core→DDM translation to fail for programs with 128-bit literals.
Add explicit bv128 arms to both, mirroring the existing bv64 pattern.
Warning: This repository will shortly undergo a split into several separate repositories. If you're creating a PR that crosses the boundaries between these repositories, you may want to hold off until the split is complete or be prepared to rework your PR into multiple PRs once the split is complete.
The code that will be moved includes: