(closes #2813) Migrate to pyproject.toml#3434
Open
sergisiso wants to merge 9 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3434 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 391 391
Lines 54668 54668
=======================================
Hits 54649 54649
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@LonelyCat124 @arporter This is ready for a first review |
LonelyCat124
previously approved these changes
May 19, 2026
Collaborator
LonelyCat124
left a comment
LonelyCat124
left a comment
There was a problem hiding this comment.
Looks like this should work. I'm going to set the ITs going just in case, but otherwise it all seems fine.
Collaborator
|
@sergisiso I think maybe this an issue with my setup but I just wanted to check, but my flake8 on Not sure if error on my setup or something else? But only happens on this branch. |
Collaborator
Author
|
These are the flake8 exceptions listed in the settings, by default flake8 does not read pyproject setting but I had introduced the flake8-pyproject that is supposed to do that. But apparently is conflicting with flake8 if it is already installed in the environment. I will revert this for now as I want to discuss other solutions when I am back. |
LonelyCat124
added
reviewed with actions
ready for review
and removed
ready for review
reviewed with actions
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left the
data_filesin setup.py because they can not be easily migrated with the current file structure. Everything else has been migrated.