Introduce rb_proc_new and test it#21
Open
tinco wants to merge 1 commit into
Open
Conversation
Owner
Not at all! And I agree 100%. I'm not mega mega familiar with the details here, so I'll give this a real review at some point, but I can't right now. Thank you for the PR! |
Author
|
This PR was not 100% correct, after reading a bunch of Ruby code and some help from the rust IRC channel I fully understand how it works now. I've got working code in my branch now, I'll clean it up and push it to this PR when I get some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried making it accept more than one arguments, but failed. If I make it be variadic, and then transmute multi-argument function references to that, the second argument will still always be nil. I don't know enough about variadic argument functions to understand why this would happen.
I'm not sure if this is good to merge in as it is, since a proper variadic implementation might not be compatible with consumers of this API.
Also, I hope you don't mind I made a test for it, it helped find the right signatures and finding out if all the values were being set correctly. Also I think it's nice if there's examples of how to use these functions in here, because there sure aren't any in the Ruby codebase.