Add LedgerEntry to LedgerKey conversion#421
Merged
leighmcculloch merged 7 commits intomainfrom Mar 17, 2025
Merged
Conversation
dmkozh
reviewed
Mar 17, 2025
dmkozh
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add to_key() conversion method for LedgerEntry and it's sub-types types.
Why
Enable direct conversion from LedgerEntry to LedgerKey to simplify working with ledger entries. In some application code we've had to construct ledger keys from ledger entries, and having this conversion logic in the stellar-xdr lib would be helpful.