Set empty top-level permissions in claude-review#1864
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the claude-review GitHub Actions workflow by explicitly setting top-level GITHUB_TOKEN permissions to none, ensuring all jobs must opt in to the minimum required scopes.
Changes:
- Add
permissions: {}at the workflow root level to enforce zero default token permissions. - Preserve least-privilege behavior by relying on the existing job-level permissions for the
reviewjob.
fnando
approved these changes
May 8, 2026
mootz12
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
permissions: {}at the workflow top level in.github/workflows/claude-review.yml, after theconcurrencyblock and beforejobs.Why
Without an explicit top-level
permissionsblock, jobs inherit whatever defaultGITHUB_TOKENpermissions the repository or organization grants. Settingpermissions: {}at the workflow level enforces zero default permissions and forces every job to opt in to the exact scopes it needs (thereviewjob already declares its owncontents: read,pull-requests: write,id-token: write). This is the GitHub-recommended least-privilege hardening pattern and prevents future jobs added to this file from silently inheriting broad token scopes.