model['config'] can be null#499
Open
mattiamatrix wants to merge 3 commits into
Open
Conversation
mattiamatrix
commented
Aug 28, 2025
| {%- endmacro -%} | ||
|
|
||
| {% macro comment(comment) %} | ||
| {%- set persist_docs = model['config'].get('persist_docs') -%} |
Author
There was a problem hiding this comment.
I don't mind the implementation, but that's the idea. model['config'] can return null.
The code should be updated to make it safer.
Author
|
@damian3031 can you please take a look at this? |
Author
|
@damian3031 please? |
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is required to fix an issue detected in elementary-data/elementary#1886.
Calling
trino__create_table_asand then callingcommentcauses a crash becausemodeldoes not have a "config" key.model['config']is used in other areas of the code; it should probably be updated to make it more robust!Fixes error
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry