feat: integrate gateway api endpoint for chart#570
Open
tboerger wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support in the Helm chart for deploying a Gateway API HTTPRoute resource (as an alternative to Ingress/OpenShift Route) and bumps the chart/app versions to align with the updated Forecastle image.
Changes:
- Bump chart version/appVersion and default image tag (
v2.0.1). - Add
forecastle.httpRouteconfiguration tovalues.yaml. - Add a new
templates/httproute.yamlHelm template to render anHTTPRoutewhen enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| deployments/kubernetes/chart/forecastle/values.yaml | Adds httpRoute values block and updates default chart/image versions. |
| deployments/kubernetes/chart/forecastle/templates/httproute.yaml | Introduces Helm template to render Gateway API HTTPRoute resources. |
| deployments/kubernetes/chart/forecastle/Chart.yaml | Bumps chart version and appVersion to 1.5.0 / v2.0.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
msafwankarim
left a comment
msafwankarim
left a comment
There was a problem hiding this comment.
Thank you for your PR submission. Please merge master again to fix Test Helm pipeline and resolve the comments from copilot
tboerger
force-pushed
the
feat/gateway-api
branch
from
329706a to
5570c56
Compare
The Gateway API had been established as the new standard as an alternative for Ingress resources. With this change it's possible to deploy the HTTPRoute resource directly as part of the chart. Signed-off-by: Thomas Boerger <thomas@webhippie.de>
tboerger
force-pushed
the
feat/gateway-api
branch
from
5570c56 to
d078801
Compare
Author
|
@msafwankarim I have updated the PR as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gateway API had been established as the new standard as an alternative for Ingress resources. With this change it's possible to deploy the HTTPRoute resource directly as part of the chart.