feat(telemetryrouter): Onboarding TelemetryRouter#1425
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
…ackit into feature/telemetryrouter
| "config_filter_matcher": config.StringVariable("="), | ||
| "config_filter_value0": config.StringVariable("value1"), | ||
| "config_filter_value1": config.StringVariable("value2"), | ||
| "config_opentelemetry_bearer_token": config.StringVariable("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"), |
There was a problem hiding this comment.
You should not use hard coded token like that. This wont work.
There was a problem hiding this comment.
Destination represents an external destination logs are sent to. So it is a value, which a service user provides, not something that is generated by us.
There was a problem hiding this comment.
The only possibility I probably see is to use another instance as a destination with a token created for that instance. Should it be done that way?
There was a problem hiding this comment.
What is meant by the external destination ? Where is this token generated and provided? Do we have another resource dependency? What is the lifetime of this token?
In worst case scenario, the token must be given via ENV variable. Cause we want to run our acc tests without changing the code base with new values.
There was a problem hiding this comment.
Telemetry Router allows logs to be sent to external destination added by a customer. It is just a minimal token from https://www.jwt.io. But we've recently added a health check on Destination creation in order to be sure that logs can be sent to it. That means I'll have to add another Telemetry Router instance with a token created for it and use it as a target for the Destination.
Co-authored-by: Gökce Gök Klingel <161626272+GokceGK@users.noreply.github.com>
Co-authored-by: Gökce Gök Klingel <161626272+GokceGK@users.noreply.github.com>
Description
Telemetry Router resources and datasource
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)