Use Provided ContextSource in PoolingContextSource Constructor - #1569
Merged
jzheaux merged 1 commit intoAug 27, 2026
Merged
Conversation
The ContextSource constructor argument was ignored and a NullContextSource was passed to the pool factory instead, so borrowing a context always failed. Closes spring-projectsgh-1545 Signed-off-by: Alexander Makarov <alexander.makarov@nightsong.li>
jzheaux
force-pushed
the
fix/gh-1545-pooling-contextsource-ignored
branch
from
August 26, 2026 23:43
ddaac27 to
ebb420d
Compare
Collaborator
|
Good catch, @MacAlsandair! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ContextSource constructor argument was ignored and a NullContextSource was passed to the pool factory instead, so borrowing a context always failed.
Closes gh-1545