Refine dialect specific escaping. - #2328
Open
schauder wants to merge 2 commits into
Open
Conversation
mp911de
reviewed
Aug 11, 2026
| * @return new instance of {@link Escaper}. | ||
| * @since 4.1 | ||
| */ | ||
| public static Escaper of(char escapeCharacter, Set<String> toReplace) { |
Member
There was a problem hiding this comment.
Above deprecated since 4.2, and this method says it has been introduced with 4.1
mp911de
reviewed
Aug 11, 2026
| @Test // GH-2325 | ||
| public void doublesSingleQuoteWhenEscapeCharacterIsSingleQuote() { | ||
|
|
||
| Escaper escaper = Escaper.of('\'', Set.of("'")); |
Member
There was a problem hiding this comment.
Creation with multiple strings removes any semantic context if one isn't familiar with the parameter ordering, it's a bunch of chars and strings after all. We should look for a bit more expressiveness. Escaper.create(it -> it.escape("_", "%").with("\\")) or Escaper.of(Target.ofStrings("_", "%"), EscapeChar.of('\\'))
Contributor
Author
|
I addressed the issue. Please have another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2325