process: raise descriptive error when input looks like integer samples#464
Open
gijzelaerr wants to merge 2 commits intospotify:masterfrom
Open
process: raise descriptive error when input looks like integer samples#464gijzelaerr wants to merge 2 commits intospotify:masterfrom
gijzelaerr wants to merge 2 commits intospotify:masterfrom
Conversation
Detect when users pass integer-valued audio samples (e.g. raw 16-bit PCM values like -32768 to 32767) to process() instead of the expected floating-point samples in [-1, 1]. The check triggers only when ALL samples are exact integers AND at least one sample falls outside [-1, 1], avoiding false positives on silence or quiet audio. Closes spotify#407 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when users pass integer-valued audio samples (e.g. raw 16-bit PCM values like -32768 to 32767) to process() instead of the expected floating-point samples in [-1, 1]. The check triggers only when ALL samples are exact integers AND at least one sample falls outside [-1, 1], avoiding false positives on silence or quiet audio.
Closes #407