Skip to content

Add support for reading WAV files containing ADPCM, A-law, µ-law, or 64-bit float data.#449

Merged
psobot merged 6 commits intomasterfrom
psobot/add-adpcm
Jan 14, 2026
Merged

Add support for reading WAV files containing ADPCM, A-law, µ-law, or 64-bit float data.#449
psobot merged 6 commits intomasterfrom
psobot/add-adpcm

Conversation

@psobot
Copy link
Copy Markdown
Member

@psobot psobot commented Jan 13, 2026

Does what it says on the tin; ADPCM, A-law, and µ-law are all different compression types commonly stored within WAV files, but we don't currently support them (nor do we support 64-bit floating-point WAV files).

This PR vendors the excellent dr_wav library from @mackron to handle reading these additional formats.

@psobot psobot marked this pull request as ready for review January 13, 2026 15:41
@psobot psobot requested review from hyperc54 and tdhopper January 13, 2026 15:44
@psobot psobot changed the title Add ADPCM, A-law, and µ-law support. Add support for reading WAV files containing ADPCM, A-law, µ-law, or 64-bit float data. Jan 13, 2026
Copy link
Copy Markdown

@caravanuden caravanuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments! otherwise, looks great. happy to re-review whenever!

Comment thread pedalboard/juce_overrides/juce_PatchedWavAudioFormat.h Outdated
Comment thread pedalboard/juce_overrides/juce_PatchedWavAudioFormat.h Outdated
Comment thread pedalboard/juce_overrides/juce_PatchedWavAudioFormat.h Outdated
Comment thread tests/test_io.py
Comment thread tests/test_io.py
Copy link
Copy Markdown

@caravanuden caravanuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for addressing my review

@psobot psobot merged commit 4b8ba5e into master Jan 14, 2026
37 checks passed
@psobot psobot deleted the psobot/add-adpcm branch January 14, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants