Add support for reading WAV files containing ADPCM, A-law, µ-law, or 64-bit float data.#449
Merged
Add support for reading WAV files containing ADPCM, A-law, µ-law, or 64-bit float data.#449
Conversation
caravanuden
reviewed
Jan 14, 2026
caravanuden
left a comment
There was a problem hiding this comment.
a few comments! otherwise, looks great. happy to re-review whenever!
caravanuden
approved these changes
Jan 14, 2026
caravanuden
left a comment
There was a problem hiding this comment.
LGTM! thanks for addressing my review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin; ADPCM, A-law, and µ-law are all different compression types commonly stored within WAV files, but we don't currently support them (nor do we support 64-bit floating-point WAV files).
This PR vendors the excellent
dr_wavlibrary from @mackron to handle reading these additional formats.