Skip to content

Fix typos in Task.get_param_names: include_significant -> include_insignificant #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nayopu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typos in Task.get_param_names: include_significant -> include_insignificant #3168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions luigi/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,8 @@ def batch_param_names(cls):
return [name for name, p in cls.get_params() if p._is_batchable()]

@classmethod
def get_param_names(cls, include_significant=False):
return [name for name, p in cls.get_params() if include_significant or p.significant]
def get_param_names(cls, include_insignificant=False):
return [name for name, p in cls.get_params() if include_insignificant or p.significant]

@classmethod
def get_param_values(cls, params, args, kwargs):
Expand Down