Merged
Conversation
RavenTait
requested review from
ljstella,
nasbench and
patel-bhavin
as code owners
Contributor
|
Moving this to v5.25.0 since the TA missed out on this release. |
Contributor
|
Added the OSquery TA. So now unit testing should pass if the searches are accurate. This PR is now targeting 5.26 |
Contributor
|
FYI. My review is in progress |
nasbench
requested changes
Apr 13, 2026
Contributor
nasbench
left a comment
nasbench
left a comment
There was a problem hiding this comment.
Overall LGTM just some minor metadata updates like RBA stuff, references and some logic suggestions/questions
patel-bhavin
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Mac OS detections and analytic stories
Detections:
Stories