Changes needed to support both old and new cluster configuration #217
Open
BSonPosh wants to merge 4 commits intosplunk:masterfrom
Open
Changes needed to support both old and new cluster configuration #217BSonPosh wants to merge 4 commits intosplunk:masterfrom
BSonPosh wants to merge 4 commits intosplunk:masterfrom
Conversation
8.1< slave/master 8.1 >= peer/manager
dtwersky
reviewed
Aug 29, 2024
| failed_when: idxc_peer_init_result.rc != 0 | ||
| notify: restart splunk | ||
| no_log: true | ||
| no_log: false |
Collaborator
There was a problem hiding this comment.
Change this back to true
dtwersky
reviewed
Aug 30, 2024
Author
|
I don’t think I did that. Good catch
…On Fri, Aug 30, 2024 at 8:55 AM dtwersky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In roles/splunk/tasks/configure_idxc_manager.yml
<#217 (comment)>
:
> set_fact:
- mode_value: "{% if splunk_version_release | float < 8.1 %}master{% else %}manager{% endif %}"
+ mode_value: "manager"
Have you tried using the old method but changing it from float to version?
Using float was wrong because it will fail in some cases when there are
micro releases.
—
Reply to this email directly, view it on GitHub
<#217 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE6UWZXMZLOJJVS5MXIP33ZUBTV3AVCNFSM6AAAAABNLAEHWGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRZHAYTSNJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dtwersky
reviewed
Aug 30, 2024
|
|
||
| - name: Setting clustering mode to slave and uri to master base on Splunk version | ||
| set_fact: | ||
| mode_value: "slave" |
Collaborator
There was a problem hiding this comment.
And this:
Suggested change
| mode_value: "slave" | |
| mode_value: "{% if splunk_version_release | version('8.1', '<') %}slave{% else %}peer{% endif %}" |
These changes (if tested and working) will combine both 8.1 and later into one task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.1< slave/master
8.1 >= peer/manager