Expose SignalFx 4xx API error details across provider

[tnoff]

Issue: When creating/updating chart resources, 400 responses do not show the response text to show the exact error of why something failed

Workaround: Currently if you run the terraform command with TF_LOG=debug in the front to show the full response back from the API the error is shown

Proposal: Expose the 4xx api details for charts

[MovieStoreGuy]

Hey @tnoff,

Thank you for your contribution :D

I apologise because my attention is elsewhere for the moment, and I'd like to give this the attention it deserves.
Please give me a week to come back to have a thorough look through this and provide feedback.

For the time being I'll run the pipeline to perform the simple validation.

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.29%. Comparing base (530b367) to head (4ae4f0c).
⚠️ Report is 44 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/common/error.go	54.54%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   94.38%   94.29%   -0.09%     
==========================================
  Files          77       77              
  Lines        3813     3842      +29     
==========================================
+ Hits         3599     3623      +24     
- Misses        143      145       +2     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tnoff]

@MovieStoreGuy thank you! I just added some updates to hopefully address the issues it found in the original commit

[MovieStoreGuy]

Have not forgotten about this sorry, just thought these errors were already expanded as part of the decorators.

Let me double check why that isn't the case.

[MovieStoreGuy]

Hey @tnoff ,

I had recently added https://github.com/splunk-terraform/terraform-provider-signalfx/blob/main/signalfx/provider_decorator.go#L37:L53 into the provider that should be doing the same thing as you're attempting to do. Is this not working for you?

[tnoff]

@MovieStoreGuy ah lemme try that, I believe we're on 9.7.2, lemme update to 9.21.0 per d113862

[MovieStoreGuy]

Was there any updates @tnoff ?