Repository navigation
refactor: retire manifest v1-v7, fix daily-loop bugs, guard shared primitives - #20
Merged
Merged
Conversation
…only Remove the v1-v6 reconcile/journal/provider stack and the v7 pilot, merge the filesystem, baseline and manifest primitives that version 8 still needs, name modules and error codes by capability instead of delivery, and drop legacy tests, fixtures and experiments.
…layers, recover from stale baselines
…e duplication review skill
…se skill author-facing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires manifest versions 1-7 and keeps the version 8 engine as the only contract, removes the redundant guards and copies that the retirement exposed, fixes three daily-loop bugs, and adds a guard against new duplicate primitives.
luwu.sensitivity.is_sensitive_namereplaces five disagreeing predicates. Filesystem guards that mutation testing proved redundant are deleted. Three fault-injection tests cover the checks that were not covered.baseline_staleand recovers with an explicit re-accept.tests/tooling/test_primitive_ownership.pyfails when a module outside the owner callsos.replace,os.open,json.loads, and similar primitives. Ceilings record known debt. The project skillluwu-primitive-reuse(renamed from the first draft) triggers on the author's action.AGENTS.mdis unchanged.uv.lockstays on public PyPI (a mirror rewrite was committed and then reverted). Hook revisions for ruff and ty are bumped.Known debt (not in this PR)
manifest.py(7 calls) andengine.py(1 call) still carry their own no-follow directory walks, andbaseline.pyandformats.pyeach calljson.loadsfor their own parse. The ownership test caps these. They are listed indocs/status.md. Merging the walks intoluwu/filesystem.pyis a follow-up.Validation
python -m unittest discover -s tests -t .: 223 tests pass on Python 3.13. The 220-test suite also passed on 3.12 and against the installed wheel before the last additions.prek run --all-files: all hooks pass (ruff, ty, mdformat, uv-lock).uv build,profile_ablation.py, and the benchmark smoke run passed earlier in the branch.