Skip to content

[test]: hide base tables without attachments#8353

Open
rijulpoudel wants to merge 1 commit into
mainfrom
issue-8350
Open

[test]: hide base tables without attachments#8353
rijulpoudel wants to merge 1 commit into
mainfrom
issue-8350

Conversation

@rijulpoudel

@rijulpoudel rijulpoudel commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #8350

Summary by CodeRabbit

  • Tests
    • Added coverage for displaying base table options.
    • Verified filtering to attachment-related tables.
    • Confirmed selecting an attachment table triggers the expected action.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: acb210d6-29be-49b7-ae28-620e2abd4c24

📥 Commits

Reviewing files that changed from the base of the PR and between 1669426 and ff3caf1.

📒 Files selected for processing (1)
  • specifyweb/frontend/js_src/lib/components/WbPlanView/__tests__/Components.test.tsx

📝 Walkthrough

Walkthrough

Changes

Attachment table selection

Layer / File(s) Summary
Attachment filtering and selection validation
specifyweb/frontend/js_src/lib/components/WbPlanView/__tests__/Components.test.tsx
Adds tests verifying default table rendering, exclusion of tables without attachments when onlyAttachmentTables is enabled, and the Accession click callback.
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds tests for the behavior, but it does not show any production change that prevents selecting unsupported base tables. Add the implementation that blocks selection of base tables without attachments, then keep or update the tests to cover the fix.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly matches the test-focused change about hiding base tables without attachments.
Out of Scope Changes check ✅ Passed The only change is a focused test file, which stays within the stated test scope and adds no unrelated work.
Automatic Tests ✅ Passed Yes—PR adds a Jest/RTL test file for WbPlanView that verifies attachment-only filtering and click behavior.
Testing Instructions ✅ Passed The new test clearly targets ListOfBaseTables and verifies both default and attachment-only filtering, matching the BaseTableSelection/Wrapped flow.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8350

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-85

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=830

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-108

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@rijulpoudel rijulpoudel added this to the 7.12.1 milestone Jul 24, 2026
@rijulpoudel

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit Full Review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 52 minutes.

@rijulpoudel

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit Full review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

[test]: Prevent selecting base tables that do not support attachments

1 participant