[test]: preserve imported data and mapping#8342
Conversation
|
Warning One or more dependencies are approaching or past End-of-Life. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Django test that creates a WorkBench dataset with imported data, applies an upload plan, retrieves the dataset, and verifies the columns, rows, and mapping are preserved. ChangesImported dataset preservation
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@specifyweb/backend/workbench/tests.py`:
- Around line 168-172: Update the row assertion in the affected test to compare
dataset["rows"] directly with rows rather than slicing each row to len(columns).
Keep the existing column assertion and ensure the test enforces complete row
payload and row/column alignment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0b066057-831c-46bf-bf03-0017c08cfb7d
📒 Files selected for processing (1)
specifyweb/backend/workbench/tests.py
|
@CodeRabbit Full review |
✅ Action performedFull review finished. |
Fixes #8338
Summary by CodeRabbit