Skip to content

fix(core/link-to-dfn): use parentElement.closest() for scoping hint #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoscaceres wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(core/link-to-dfn): use parentElement.closest() for scoping hint #5261

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
405beb3
fix(core/link-to-dfn): use parentElement.closest() for scoping hint
marcoscaceres May 4, 2026
a1e7183
fix: normalize type annotation and add regression test
marcoscaceres May 4, 2026
6d7b6e0
Merge branch 'main' into fix/5257-closest-self-match
marcoscaceres May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/link-to-dfn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,9 @@ function showLinkingError(elems) {
// Check if the link is inside a data-link-for section — a common footgun
// where [=global-term=] gets scoped to the interface and fails.
const scopedSection = /** @type {HTMLElement | null} */ (
elem.closest("[data-link-for]")
elem.parentElement?.closest("[data-link-for]")
Comment thread
marcoscaceres marked this conversation as resolved.
Outdated
);
const scopingNote = scopedSection
const scopingNote = scopedSection?.dataset.linkFor
? ` This link is inside a \`data-link-for="${scopedSection.dataset.linkFor}"\` section — \`[=term=]\` links are scoped to that context. To link to a global concept instead, either add \`data-link-for=""\` on this \`<a>\` or move it outside the scoped section.`
: "";
Comment thread
marcoscaceres marked this conversation as resolved.
const hint = `Add a matching \`<dfn>\` element, ${docLink`use ${"[data-cite]"} to link to an external definition, or enable ${"[xref]"} for automatic cross-spec linking.`}${scopingNote}`;
Expand Down
Loading