Now will distinguish between status codes the expected inferred type#1957
Open
carloscbl wants to merge 2 commits intospec-first:mainfrom
Open
Now will distinguish between status codes the expected inferred type#1957carloscbl wants to merge 2 commits intospec-first:mainfrom
carloscbl wants to merge 2 commits intospec-first:mainfrom
Conversation
Member
|
Thanks @carloscbl! Tests are failing though. Not sure if this is due to an issue with your code, or because the failing tests depend on the old behavior. |
|
Hi, I just found this PR. |
Contributor
|
The test outputs that showed a failure have expired. Please rebase etc. and push, then hopefully the Github workflow will run again here. Thanks. |
Contributor
|
@carloscbl maybe you'd like to close this PR, since @Boxap opened #2100 with the same content? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1956 and #1850 .
Changes proposed in this pull request: