Feat/testing api alpha#598
Draft
christianSozialhelden wants to merge 34 commits intobetafrom
Draft
Conversation
This fixes an issue with a SSR code trying to access the browser localStorage API which isn't available when the code runs inside the server side scope. The code did not work anymore because it checked for the existence of a `localStorage` global – which exists, because the app creates a stub of it as empty object (this behavior seems to have changed recently, and is probably related to web packaging). The new code checks for the existence of a `window` global to find out if it is running inside SSR code. This seems to reliably work on the server side.
This adds `Dockerfile.testing` and `run_tests.sh` files that reliably test the app with Playwright using base URL that the CI process can hand over as environment variable. Transifex Native CDN loading still hangs in CI tests, we have to fix that in another step.
- Use `pnpm` instead of `npm` - Use `corepack`/`buildkit` for container build layer caching - Improve build speed and container image size - Fix vulnerabilities - Require newer node engine in `package.json`
This reverts commit 3f8e012.
…eat/integrate-e2e-tests
This reverts commit 5c82cb8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.