fix: propagate 404 status code instead of 500 for missing resources#579
Open
opyh wants to merge 10 commits intoproductionfrom
Open
fix: propagate 404 status code instead of 500 for missing resources#579opyh wants to merge 10 commits intoproductionfrom
opyh wants to merge 10 commits intoproductionfrom
Conversation
This was missing, causing 404s in backend calls to be shown as HTTP 500 to app clients.
…pagation The _app.tsx error handler already extracts error.status || error.statusCode, but ResponseError didn't expose these properties. This caused all backend errors (including 404) to be caught and converted to 500. Now ResponseError exposes status/statusCode getters that return the HTTP status from the underlying response, allowing 404s to propagate correctly.
opyh
force-pushed
the
fix/propagate-404-status-code
branch
from
abc236f to
fba5a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix backend 404 errors being converted to 500 errors on the frontend.
Problem
When accessing a non-existent mapping event (e.g.,
/events/THIS_ID_DOES_NOT_EXIST), the backend correctly returns a 404, but the frontend was showing a 500 error.Root Cause
The
_app.tsxerror handler already extractserror.status || error.statusCode || 500to set the response status code, butResponseErrorclass didn't expose these properties. The error was caught, but sincestatus/statusCodewere undefined, it defaulted to 500.Solution
Added
statusandstatusCodegetters toResponseErrorclass that return the HTTP status from the underlying response object.Testing
npm run devhttp://localhost:3000/events/THIS_ID_DOES_NOT_EXISTcurl -I http://localhost:3000/events/THIS_ID_DOES_NOT_EXISTshould showHTTP/1.1 404(Asana link)