Skip to content

Add more tests#484

Open
NinaEilers wants to merge 27 commits intofeature/a11ymapfrom
feature/a11ymap-tests
Open

Add more tests#484
NinaEilers wants to merge 27 commits intofeature/a11ymapfrom
feature/a11ymap-tests

Conversation

@NinaEilers
Copy link
Copy Markdown
Collaborator

@NinaEilers NinaEilers commented Jan 25, 2025

E2E Tests for parking space accessibility

Asana-Ticket: https://app.asana.com/0/1213356985075012/1208010078664178

Tests added

  • Test that accessible parking spaces dont show "Unnamed place"
  • Test for accessibility indicators presence
  • Test ARIA structure
  • Axe accessibility scan

Code Analysis

Found issues in current implementation:

  1. Tags like parking_space=disabled, disabled=designated not recognized as parking category
  2. isWheelchairAccessible() missing logic for these tags
  3. Legacy config table with 14 tag combinations not ported to new code

See: src/lib/model/accessibility/isWheelchairAccessible.ts

@opyh opyh changed the title Description of adding a picture Add more tests Mar 4, 2025
and add some not-working to the tests working
delete test-1, test-5, test-11
@NinaEilers NinaEilers requested a review from opyh March 14, 2025 11:14
@opyh opyh self-assigned this May 14, 2025
- Add .github/copilot-instructions.md with project overview
- Add .github/instructions/testing.instructions.md with:
  - Playwright test patterns (ARIA-first selectors)
  - Accessibility best practices (tab order, semantics)
  - Asana MCP integration workflow
  - CI test backlog linking
- Add e2e/darkmode-logo.spec.ts with 5 tests:
  - Logo visibility in light/dark mode
  - Contrast check for dark mode (documents bug)
  - Axe accessibility scans for both modes
- Update testing.instructions.md with dev server note

Asana: https://app.asana.com/1/1200321573365931/project/1213356985075012/task/1210099669460115
…8664178)

- Test that accessible parking spaces don't show 'Unnamed place'
- Test for accessibility indicators presence
- Test ARIA structure
- Axe accessibility scan
@opyh opyh enabled auto-merge February 19, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants