Repository navigation
Conversation
**What does this PR address? (Why)** Expose original JVM variable slots and distinguish operand-stack temporaries for downstream analyses and code generation, preserving metadata during local transformations. **What are the main implementation details? (What, How)** - Make `Local` and `JavaLocal` interfaces, with shared `AbstractLocal` behavior and composable slot/stack and Java annotation variants. - Add `newSlotLocal` and `newStackLocal` factories with private implementations and metadata-preserving withers; migrate constructor calls. - Record provenance during bytecode conversion and preserve it during renaming and serialization; add slot, wide-parameter, and transformation tests. Validation: clean core, Java core, interceptor, and both frontend suites (786 passed, 14 skipped); formatting passed. **Linked issue (if any)** None. **Checklist** *Code style & guidelines* - [x] I ran the formatter: `mvn com.spotify.fmt:fmt-maven-plugin:format` - [x] I added the necessary comments in the code - [x] I provided meaningful tests for my proposed change - [x] I updated documentation (if needed) *Self-review* - [x] I performed a self-review of my code - [x] I added or updated tests where needed - [x] I have successfully run tests with my changes locally - [ ] My branch is up to date with `develop` *Review* - [ ] CI checks are green - [x] I requested a review from a core contributor
7 of 10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address? (Why)
Expose original JVM variable slots and distinguish operand-stack temporaries for downstream analyses and code generation, preserving metadata during local transformations.
What are the main implementation details? (What, How)
LocalandJavaLocalinterfaces, with sharedAbstractLocalbehavior and composable slot/stack and Java annotation variants.newSlotLocalandnewStackLocalfactories with private implementations and metadata-preserving withers; migrate constructor calls.Validation: clean core, Java core, interceptor, and both frontend suites (786 passed, 14 skipped); formatting passed.
Linked issue (if any)
None.
Checklist
Code style & guidelines
mvn com.spotify.fmt:fmt-maven-plugin:formatSelf-review
developReview