Give each menu button its own popover - #219
Merged
Merged
Conversation
Both MenuButtons pointed at a single shared PopoverMenu instance. A GtkPopover can only have one parent, so GTK reparented it and logged gtk_widget_set_parent criticals on every launch. On Plasma the visible symptoms were a stray arrow pointing at the hidden header button, and the menu opening by itself. Each button now uses menu-model: and gets its own correctly parented popover from the same GMenu. The criticals go from one per launch to zero.
This was referenced Aug 4, 2026
sonnyp
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #218 as requested.
Both
MenuButtons pointed at a single sharedPopoverMenuinstance. AGtkPopovercan only have one parent, so GTK reparented it and loggedgtk_widget_set_parentcriticals on every launch. On Plasma the visible symptoms were a stray arrow pointing at the hidden header button, and the menu opening by itself.Each button now uses
menu-model:and gets its own correctly parented popover from the sameGMenu. The criticals go from one per launch to zero.