Move to Standardrb - #92
Merged
Merged
Conversation
Standard is dependency of solidus_dev_support and the default way of linting in Solidus itself. Instead of fixing and adjusting Rubocop rules, it is better to move the project to Standard use the same set of linting rules as Solidus.
Ran `bundle exec standardrb --fix` against the project and applied all changes. These are mostly single quotes to double quotes and indention issues.
This will remove follow warning during the standardrb run: lib/generators/solidus_static_content/install/install_generator.rb: Warning: Metrics/LineLength has the wrong namespace - replace it with Layout/LineLength
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Standardrb instead of Rubocop to follow the same linting rules as Solidus. This way the Lint pipeline is going to be successful again.