Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Entire-Checkpoint: d5cfe09820f4
Entire-Checkpoint: c6986f0bfa64
Entire-Checkpoint: 32425be58bb9
MicaiahReid
approved these changes
May 12, 2026
Contributor
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
LGTM! Small suggestions if you want
Comment on lines
+625
to
+630
| if static_warning_count > 0 { | ||
| lines.push(format!( | ||
| "{static_warning_count} static validation warning{}", | ||
| if static_warning_count == 1 { "" } else { "s" }, | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
Could just be:
lines.push(warning_suffix(static_warning_count);since you already have that logic captured.
| .any(|p| lowered == *p || lowered == format!("the {p}")) | ||
| { | ||
| findings.push(CatalogFinding::error(format!( | ||
| "{label}: operation summary is a generic placeholder \"{effective}\"\n \ |
Contributor
There was a problem hiding this comment.
Could be helpful to list the banned placeholders here - I could see someone feasibly trying to use on of these words
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.17.0.pay catalog checkstatic validation to reflect the updated pay-skills catalog rules:openapi.urlin registry listingspay catalog buildto publish usable free200endpoints alongside Solana-compatible paid402endpoints, while filtering unusable probe outcomes.premiumis allowed.pay topupsmall-window QR fallback copy:QR unavailableMake this window larger / to show the QR code