Skip to content

[Bindings/SofaTypes] static_assert on cross() #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnbrunet merged 1 commit into from
Feb 12, 2021
Merged

[Bindings/SofaTypes] static_assert on cross() #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions bindings/SofaTypes/src/SofaPython3/SofaTypes/Binding_Vec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,8 @@ T addCross(T p)
{
p.def("cross", [](typename T::type& a, typename T::type& b)
{
if constexpr (T::type::spatial_dimensions == 2 || T::type::spatial_dimensions == 3)
{
return sofa::type::cross(a, b);
}
else
{
// can only call cross with vec2 or vec3
return T();
}
static_assert(T::type::spatial_dimensions == 2 || T::type::spatial_dimensions == 3, "Cross product function can only be used with Vec2 and Vec3");
return sofa::type::cross(a, b);
});
return p;
}
Expand Down