Repository navigation
chore(deps): ignore zip advisories until the updater ships zip 9 - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo auditnow fails on three advisories added overnight againstzip4.6.1 (RUSTSEC-2026-0367, -0368, -0369): extracting an archive can write through symlinks or keep permissions outside the target directory. The fix only exists inzip9, and the crate comes fromtauri-plugin-updater, whose latest release (2.14.0) still asks forzip4, so the pre-push hook and CI block every branch.These advisories don't reach SocaDB. The updater plugin depends on
zipon Windows only, to unpack an update that arrives zipped, and it only gets there after checking the download's signature against our key: anyone able to sign an update could already ship any installer. Our Windows updates are a plain.exeanyway, and two of the three flaws are in Unix-only code. macOS updates go through Sparkle, which doesn't usezip.The three IDs join the ignore list in
src-tauri/.cargo/audit.toml, with that reason. The updater already moved tozip9 upstream (tauri-apps/plugins-workspace#3698); once a release after 2.14.0 ships it, we bump the plugin on both sides and drop the exception.