-
Notifications
You must be signed in to change notification settings - Fork 147
SNOW-2267482: Fix flakiness due to SnowAPI dependency #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 27 commits
3467b7b
143f30a
e45239a
0692a09
f610835
bfcf249
674d831
5933508
02ec3b8
c78333c
9e49c85
bc65acf
2afd738
50d0c32
9e89ca4
4334c32
701c08b
ef16ee8
d9dad80
68650b1
1906d61
bb2ef8e
e0097c9
1472367
8a9bc66
40ace28
e8cbe79
ff8a005
743620b
1e3af12
2ecc805
0608e79
1823470
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -628,6 +628,7 @@ def __init__( | |
| """ | ||
| self.version = get_version() | ||
| self._session_stage = None | ||
| self._use_sql_base_catalog = True | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Who / where / how is this flag turned off?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is controlled in SCOS at here: https://github.com/snowflake-eng/sas/pull/3822/changes#diff-e7ffc1935ec104660e3a0eccbd0693faa973359ed84d9429d28a28684fb55a38R821
sfc-gh-aling marked this conversation as resolved.
Outdated
|
||
|
|
||
| if isinstance(conn, MockServerConnection): | ||
| self._udf_registration = MockUDFRegistration(self) | ||
|
|
@@ -961,7 +962,9 @@ def catalog(self): | |
| external_feature_name="Session.catalog", | ||
| raise_error=NotImplementedError, | ||
| ) | ||
| self._catalog = Catalog(self) | ||
| self._catalog = Catalog( | ||
| self, _use_sql_base_catalog=self._use_sql_base_catalog | ||
|
sfc-gh-aling marked this conversation as resolved.
Outdated
|
||
| ) | ||
| return self._catalog | ||
|
|
||
| def close(self) -> None: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.