Skip to content

Prevent activation_checkpoint_cpu_offload from silently no-op'ing on transformers >=5.0 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xylian86 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent activation_checkpoint_cpu_offload from silently no-op'ing on transformers >=5.0 #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion arctic_training/model/hf_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ def post_create_model_callback(self, model):
)

if not self.config.disable_activation_checkpoint:
model.gradient_checkpointing_enable()
gc_kwargs = None
if self.trainer.config.activation_checkpoint_cpu_offload:
# CPU-offload monkey patch (see arctic_training.monkey_patches)
# only intercepts torch.utils.checkpoint's reentrant path.
gc_kwargs = {"use_reentrant": True}
model.gradient_checkpointing_enable(gradient_checkpointing_kwargs=gc_kwargs)
model = self.make_model_gradient_checkpointing_compatible(model)

return model