Feature: Support more experiment tracking libraries#365
Open
sfc-gh-mwyatt wants to merge 2 commits into
Open
Conversation
| user: str = "" | ||
| """ Snowflake user name. """ | ||
|
|
||
| password: str = "" |
There was a problem hiding this comment.
From managed API path, SPCS will be responsible for setting the config. SPCS job only has OAuth token available to be used. Could we support the authentication type token = <oauth_token>, authenticator = 'oauth'?
Collaborator
Author
There was a problem hiding this comment.
Sure, let me update for different auth types and I will let you test!
| warehouse: str = "" | ||
| """ Snowflake warehouse. """ | ||
|
|
||
| database: str = "" |
There was a problem hiding this comment.
Out of curiosity, are db and schema mandatory here?
Collaborator
Author
There was a problem hiding this comment.
I'm not 100% sure. There might be a default - I will verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize experiment tracking implementation and add support for snowflake ml experiment tracking.