Skip to content

Early catch config errors #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfc-gh-mwyatt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Early catch config errors #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccbfe4b
load config before launching deepspeed
sfc-gh-mwyatt Apr 14, 2025
e98c533
error on empty yaml value
sfc-gh-mwyatt Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions arctic_training/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@


def main():
from arctic_training.config.trainer import get_config

parser = argparse.ArgumentParser(
prog="arctic_training",
formatter_class=argparse.RawDescriptionHelpFormatter,
Expand All @@ -45,6 +47,9 @@ def main():
if not args.config.exists():
raise FileNotFoundError(f"Config file {args.config} not found.")

# Early catch any config errors
_ = get_config(args.config)

exe_path = shutil.which("arctic_training_run")

env = os.environ.copy()
Expand Down
3 changes: 3 additions & 0 deletions arctic_training/config/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,6 @@ def construct_mapping(self, node, deep=False):
raise ValueError(f"Duplicate '{key}' key found in YAML on line {key_node.start_mark.line + 1}.")
mapping.add(key)
return super().construct_mapping(node, deep)

def process_empty_scalar(self, node):
raise ValueError(f"Empty value found in YAML on line {node.line + 1}.")