Automatically select CPU Adam when offloading optimizer#144
Open
sfc-gh-mwyatt wants to merge 2 commits into
Open
Automatically select CPU Adam when offloading optimizer#144sfc-gh-mwyatt wants to merge 2 commits into
sfc-gh-mwyatt wants to merge 2 commits into
Conversation
sfc-gh-mwyatt
requested review from
sfc-gh-caxu,
sfc-gh-jrasley,
sfc-gh-sbekman,
sfc-gh-srajbhandari and
sfc-gh-zhyao
as code owners
Comment on lines
+339
to
+340
| if self.deepspeed.get("cpu_offload", {}).get("device", None) == "cpu" and self.optimizer.type == "fusedadam": | ||
| self.optimizer.type = "cpu_adam" |
Collaborator
There was a problem hiding this comment.
should it assert if a user has an explicit self.optimizer.type set to the wrong value? like:
zero_optimization.offload_optimizer.device.cpu is configured therefore optimizer.type=cpu_adam is required, but the config file has optimizer.type=... . Please either set it to cpu_adam or remove the explicit config and it'll be set automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a config validator that automatically modifies the optimizer type to use
cpu_adamwhen the DeepSpeed config uses optimizer offload to CPU.TODO: