Repository navigation
Goals no longer scrolls sideways: one goal across until lg, and a long name truncates on a phone (#208) - #250
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…g name truncates on a phone (#208) From md, two goal cards shared the column beside the sidebar. Below about 1000px half of it is too narrow for a card's Saved row, so the amount box shrank to 26px and Delete ran past its card and off the screen: at a 768px window the page was 774px wide. Goals now go two across only from lg, where each card has room. And the grid is grid-cols-1 below that rather than a bare grid, whose one column grew to fit a long goal name: on a 390px phone, a long made-up name made the page 447px wide instead of truncating. Measured against a local stand-in, the page is exactly as wide as the window at every width from 360 to 1440px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smilne3
force-pushed
the
fix/208-goals-narrow
branch
from
November 5, 2026 17:33
dd7fe53 to
b45cc81
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes #208. The Goals page scrolled sideways at tablet widths, and I found it could on a phone too, with a long goal name. It no longer does at any width.
What changes for you
How
The goal grid in
components/GoalsList.tsxchanged fromgrid gap-4 md:grid-cols-2togrid grid-cols-1 gap-4 lg:grid-cols-2:lg:instead ofmd:. Beside the sidebar, a card needs about 360px for its Saved row at full size: the label, the amount box, Update and Delete. Narrower, the amount box shrinks first. Two across, it was 33px wide at 900px and 95px at 1024px, so two across starts at 1024px.grid-cols-1instead of a bare grid. A bare grid's one column grows to fit its widest card, and a card's name doesn't wrap. So a long name widened every card and the page.grid-cols-1lets the column be narrower than the name, and the name's owntruncatetakes over. It's the same patternAccountListalready uses.Checked
I ran a production build against a local stand-in for Supabase, with three made-up goals, one of them with a long name, and measured the page in a browser at 14 widths from 360 to 1440px:
iPhone check
The owner checked the Vercel preview on an iPhone on 2026-11-05, against this list, and it looked good. That preview was built from b45cc81, this PR's final commit.
Closes #208.
🤖 Generated with Claude Code