Repository navigation
feat: SiloedLockReleaseTokenPool support, lock box tooling and migration - #39
Merged
Merged
Conversation
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
SyedAsadKazmi
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Siloed LockRelease token pools version 2.0, including new deployment targets, documentation, and migration workflows. It introduces a new
deploy-siloed-poolMakefile target, updates environment variable handling, and expands documentation to cover the new pool type, migration steps, and operational details. Additionally, a newforget-deploymentcommand is added to safely remove retired deployments from configuration.Makefile and Deployment Enhancements:
deploy-siloed-poolMakefile target to deploy SiloedLockRelease token pools v2.0, along with support for theSILOenvironment variable and related deployment options. [1] [2] [3]forget-deploymentMakefile target to remove retired deployment entries, with safety checks to prevent accidental removal of active/registered artifacts.Documentation Updates:
make discover-tokens(withPOOL=1) for identifying existing pools and their types/versions, and to explain liquidity management for Siloed pools. [1] [2] [3]Operational Improvements:
make discover-tokensto optionally include pool information per request whenPOOL=1is set, aiding in pool discovery and migration planning.forget-deploymentfor cleaning up old pool entries and resolving doctor warnings.These changes collectively enable seamless deployment, migration, and management of Siloed LockRelease token pools v2.0, with robust documentation and operational tooling.