Skip to content

N-03 Document LogPoller Replay#435

Merged
dhaidashenko merged 2 commits intodevelopfrom
chore/PLEX-2788-document-lp-replay
Apr 20, 2026
Merged

N-03 Document LogPoller Replay#435
dhaidashenko merged 2 commits intodevelopfrom
chore/PLEX-2788-document-lp-replay

Conversation

@dhaidashenko
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 17, 2026 17:10
@dhaidashenko dhaidashenko requested a review from a team as a code owner April 17, 2026 17:10
@github-actions
Copy link
Copy Markdown
Contributor

👋 dhaidashenko, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-evm

View full report

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the behavior and expectations of Replay for the LogPoller and the legacy EVM chain wrapper, clarifying how callers should use replay after modifying filters.

Changes:

  • Added API documentation to LogPoller.Replay in the LogPoller interface.
  • Added matching documentation to the legacy EVM chain Replay wrapper method.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/logpoller/log_poller.go Adds interface-level documentation for LogPoller.Replay semantics.
pkg/chains/legacyevm/chain.go Adds documentation to the chain wrapper’s Replay method delegating to the log poller.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/logpoller/log_poller.go
Comment thread pkg/chains/legacyevm/chain.go
@dhaidashenko dhaidashenko enabled auto-merge (squash) April 20, 2026 11:08
@dhaidashenko dhaidashenko merged commit f711fe3 into develop Apr 20, 2026
37 of 39 checks passed
@dhaidashenko dhaidashenko deleted the chore/PLEX-2788-document-lp-replay branch April 20, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants