Skip to content

PLEX-2785 L-07 Signal that LogsPerBlock Filter setting is not supported #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhaidashenko wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

PLEX-2785 L-07 Signal that LogsPerBlock Filter setting is not supported #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions pkg/logpoller/log_poller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,16 @@ func NewLogPoller(orm ORM, ec Client, lggr logger.Logger, headTracker HeadTracke
}

type Filter struct {
Name string // see FilterName(id, args) below
Addresses evmtypes.AddressArray
EventSigs evmtypes.HashArray // list of possible values for eventsig (aka topic1)
Topic2 evmtypes.HashArray // list of possible values for topic2
Topic3 evmtypes.HashArray // list of possible values for topic3
Topic4 evmtypes.HashArray // list of possible values for topic4
Retention time.Duration // maximum amount of time to retain logs
MaxLogsKept uint64 // maximum number of logs to retain ( 0 = unlimited )
LogsPerBlock uint64 // rate limit ( maximum # of logs per block, 0 = unlimited )
Name string // see FilterName(id, args) below
Addresses evmtypes.AddressArray
EventSigs evmtypes.HashArray // list of possible values for eventsig (aka topic1)
Topic2 evmtypes.HashArray // list of possible values for topic2
Topic3 evmtypes.HashArray // list of possible values for topic3
Topic4 evmtypes.HashArray // list of possible values for topic4
Retention time.Duration // maximum amount of time to retain logs
MaxLogsKept uint64 // maximum number of logs to retain ( 0 = unlimited )
// NOTE: not supported. Must be set to 0.
LogsPerBlock uint64 // rate limit ( maximum # of logs per block, 0 = unlimited )
}

// FilterName is a suggested convenience function for clients to construct unique filter names
Expand Down Expand Up @@ -275,6 +276,11 @@ func (lp *logPoller) RegisterFilter(ctx context.Context, filter Filter) error {
return pkgerrors.Errorf("at least one event must be specified")
}

if filter.LogsPerBlock != 0 {
lp.lggr.Errorw("LogsPerBlock is not supported yet, must be 0", "name", filter.Name, "filter", filter)
// error is not returned to maintain backwards compatibility, in case any clients are using LogsPerBlock field, even though it's not supported yet
}

for _, eventSig := range filter.EventSigs {
if eventSig == [common.HashLength]byte{} {
Comment thread
dhaidashenko marked this conversation as resolved.
return pkgerrors.Errorf("empty event sig")
Expand Down
Loading