Add configurable historical balance health check for finalized block#420
Open
Krish-vemula wants to merge 2 commits intodevelopfrom
Open
Add configurable historical balance health check for finalized block#420Krish-vemula wants to merge 2 commits intodevelopfrom
Krish-vemula wants to merge 2 commits intodevelopfrom
Conversation
Contributor
|
# Conflicts: # go.mod # go.sum
Krish-vemula
force-pushed
the
cre/PLEX-2476-v2
branch
from
e3f870c to
cb8d39b
Compare
product-security-plaid-production
Bot
requested review from
amit-momin,
bolekk and
matYang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement the finalized state availability check (originally PR #352) on top of the updated chainlink-framework that uses optional interfaces instead of modifying core NodeConfig/RPCClient interfaces. This avoids forcing unrelated chains (e.g. Solana) to implement boilerplate methods.
Summary
Implements the EVM finalized-state availability check used by multinode.
The check verifies that an RPC can serve historical state at the latest finalized block by calling
BalanceAtfor a configurable probe address. The check is disabled by default and only runs whenFinalizedStateCheckFailureThreshold > 0.Changes
HistoricalBalanceCheckAddressFinalizedStateCheckFailureThresholdErrors.FinalizedStateUnavailable0x0000000000000000000000000000000000000000CheckFinalizedStateAvailabilityon the EVM RPC client.finalizedtag whenFinalityTagEnabled = truelatest - FinalityDepthwhenFinalityTagEnabled = falseBalanceAtat the selected finalized block.multinode.ErrFinalizedStateUnavailable.