Skip to content

catch-low-min-tip-error#405

Closed
yashnevatia wants to merge 1 commit intodevelopfrom
catch-low-min-tip-error
Closed

catch-low-min-tip-error#405
yashnevatia wants to merge 1 commit intodevelopfrom
catch-low-min-tip-error

Conversation

@yashnevatia
Copy link
Copy Markdown
Contributor

No description provided.

@yashnevatia yashnevatia requested a review from a team as a code owner March 30, 2026 12:06
Copilot AI review requested due to automatic review settings March 30, 2026 12:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends EVM client error classification to treat “transaction gas price below minimum …” (seen on some Geth/Bor/Polygon and Erigon nodes) as a terminally-underpriced transaction, ensuring tx manager behavior is consistent across clients.

Changes:

  • Expand Geth TerminallyUnderpriced regex to also match transaction gas price below minimum.
  • Expand Erigon TerminallyUnderpriced regex similarly.
  • Add test cases covering the newly recognized error strings for both clients.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/client/errors.go Broadens Geth and Erigon terminal-underpriced regex matching to include “transaction gas price below minimum” errors.
pkg/client/errors_test.go Adds regression tests validating the new matching behavior for Geth and Erigon.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

@github-actions github-actions Bot closed this May 7, 2026
@github-actions github-actions Bot deleted the catch-low-min-tip-error branch May 7, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants