Skip to content

Add a config flags to standardize how we do things - #2316

Draft
nolag wants to merge 2 commits into
rtinianov_cre_psb_ms_1_capRegfrom
rtinianov_cre_psb_ms_1_flags
Draft

Add a config flags to standardize how we do things#2316
nolag wants to merge 2 commits into
rtinianov_cre_psb_ms_1_capRegfrom
rtinianov_cre_psb_ms_1_flags

Conversation

@nolag

@nolag nolag commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

TBD, should we have common structs for things like DB, OCR, etc? EVM and the like would then go in chainlink-evm.

…ve common structs for things like DB, OCR, etc? EVM and the like would then go in chainlink-evm.
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (16)

package github (2)
  • com/smartcontractkit/chainlink-common/pkg/config/flags — ➕ Added

  • com/smartcontractkit/chainlink-common/pkg/config/flags/tmp — ➕ Added

pkg/config/configdoc (11)
  • FieldDocsOnly — ➕ Added

  • Format — ➕ Added

  • GenerateWith — ➕ Added

  • Line — ➕ Added

  • LineArrayOfTables — ➕ Added

  • LineBlank — ➕ Added

  • LineComment — ➕ Added

  • LineField — ➕ Added

  • LineKind — ➕ Added

  • LineTable — ➕ Added

  • TOML — ➕ Added

pkg/ocrcommon (1)
  • Config — ➕ Added
pkg/sqlutil (2)
  • Config — ➕ Added

  • OpenDB — ➕ Added


📄 View full apidiff report

Comment on lines +28 to +29
// hand-written document can be turned into documentation). Implement it to document a format
// other than TOML; see TOML for the reference implementation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else did you have in mind? I thought we were leveraging TOMLs ease of parsing pretty directly here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From call: I'm worried about this being premature abstraction, but only because it is public API. If this is useful for readability besides, then keeping it internal and evolving until it is ready to be public would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants