Skip to content

Added vault fast path #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
russell-stern wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added vault fast path #2181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ flowchart
VaultBase64EncodingEnabled[/VaultBase64EncodingEnabled\]:::gate
VaultForceEmptyOCRRounds[/VaultForceEmptyOCRRounds\]:::gate
VaultOptimizationsEnabled[/VaultOptimizationsEnabled\]:::gate
VaultFastPathGetSecretsEnabled[/VaultFastPathGetSecretsEnabled\]:::gate
VaultGetSecretsShareAggregationIncludesPublicKeys[/VaultGetSecretsShareAggregationIncludesPublicKeys\]:::gate
VaultOwnerAddressCanonicalizationEnabled[/VaultOwnerAddressCanonicalizationEnabled\]:::gate
VaultJSONOmitUnpopulatedEnabled[/VaultJSONOmitUnpopulatedEnabled\]:::gate
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"VaultBase64EncodingEnabled": "false",
"VaultForceEmptyOCRRounds": "false",
"VaultOptimizationsEnabled": "false",
"VaultFastPathGetSecretsEnabled": "false",
"VaultGetSecretsShareAggregationIncludesPublicKeys": "false",
"VaultOwnerAddressCanonicalizationEnabled": "false",
"VaultJSONOmitUnpopulatedEnabled": "false",
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ PropagateOrgIDInRequestMetadata = 'false'
VaultBase64EncodingEnabled = 'false'
VaultForceEmptyOCRRounds = 'false'
VaultOptimizationsEnabled = 'false'
VaultFastPathGetSecretsEnabled = 'false'
VaultGetSecretsShareAggregationIncludesPublicKeys = 'false'
VaultOwnerAddressCanonicalizationEnabled = 'false'
VaultJSONOmitUnpopulatedEnabled = 'false'
Expand Down
16 changes: 9 additions & 7 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ var Default = Schema{
VaultBase64EncodingEnabled: Bool(false),
VaultForceEmptyOCRRounds: Bool(false),
VaultOptimizationsEnabled: Bool(false),
VaultFastPathGetSecretsEnabled: Bool(false),
VaultGetSecretsShareAggregationIncludesPublicKeys: Bool(false),
VaultOwnerAddressCanonicalizationEnabled: Bool(false),
VaultJSONOmitUnpopulatedEnabled: Bool(false),
Expand Down Expand Up @@ -318,24 +319,25 @@ var Default = Schema{
}

type Schema struct {
WorkflowLimit Setting[int] `unit:"{workflow}"`
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
GatewayIncomingPayloadSizeLimit Setting[config.Size]
GatewayVaultManagementEnabled Setting[bool]
VaultJWTAuthEnabled Setting[bool]
CentralizedWorkflowOwnerVerificationEnabled Setting[bool]
WorkflowLimit Setting[int] `unit:"{workflow}"`
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
GatewayIncomingPayloadSizeLimit Setting[config.Size]
GatewayVaultManagementEnabled Setting[bool]
VaultJWTAuthEnabled Setting[bool]
CentralizedWorkflowOwnerVerificationEnabled Setting[bool]
// RemoteExecutableWorkflowDONBindingEnabled, when true, makes the remote
// executable capability server reject any request whose
// RequestMetadata.WorkflowDonID does not match the authenticated calling DON
// (msg.CallerDonId). Binds caller-supplied WorkflowDonID to the authenticated
// sender DON so it cannot be spoofed by a colluding calling DON.
RemoteExecutableWorkflowDONBindingEnabled Setting[bool]
RemoteExecutableWorkflowDONBindingEnabled Setting[bool]
TenantID Setting[uint64]
VaultOrgIdAsSecretOwnerEnabled Setting[bool] // Deprecated
PropagateOrgIDInRequestMetadata Setting[bool]
VaultBase64EncodingEnabled Setting[bool]
VaultForceEmptyOCRRounds Setting[bool]
VaultOptimizationsEnabled Setting[bool]
VaultFastPathGetSecretsEnabled Setting[bool]
VaultGetSecretsShareAggregationIncludesPublicKeys Setting[bool]
VaultOwnerAddressCanonicalizationEnabled Setting[bool]
VaultJSONOmitUnpopulatedEnabled Setting[bool]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.False(t, cfg.VaultBase64EncodingEnabled.DefaultValue)
assert.False(t, cfg.VaultForceEmptyOCRRounds.DefaultValue)
assert.False(t, cfg.VaultOptimizationsEnabled.DefaultValue)
assert.False(t, cfg.VaultFastPathGetSecretsEnabled.DefaultValue)
assert.False(t, cfg.VaultGetSecretsShareAggregationIncludesPublicKeys.DefaultValue)
assert.False(t, cfg.VaultOwnerAddressCanonicalizationEnabled.DefaultValue)
assert.False(t, cfg.VaultJSONOmitUnpopulatedEnabled.DefaultValue)
Expand Down
Loading