CCIP-9669 finality checker metrics interface

[bukata-sa]

Refactor metric interfaces in executor and verifier to tighten ownership and separate checker-specific metrics.

Executor

• MetricLabeler now embeds ccvcommon.CurseCheckerMetrics.
• Removed the curse-related methods that were previously inlined on MetricLabeler.

Verifier

• Added a new FinalityCheckerMetrics interface for finality violation metrics.
• MetricLabeler now embeds both FinalityCheckerMetrics and common.CurseCheckerMetrics.
• Moved the relevant methods out of MetricLabeler and into the dedicated interfaces.

Finality checker service

• FinalityViolationCheckerService now depends on FinalityCheckerMetrics instead of the broader MetricLabeler.
• Updated the constructor to match the new interface boundary.

Shared verifier interfaces

• Exported FinalityCheckerMetrics from verifier/pkg

[github-actions]

Code coverage report:

Package	main	ccip-9669/ccip_o11y_finality_violation	diff
github.com/smartcontractkit/chainlink-ccv/aggregator	48.46%	48.46%	+0.00%
github.com/smartcontractkit/chainlink-ccv/bootstrap	42.60%	42.60%	+0.00%
github.com/smartcontractkit/chainlink-ccv/cli	65.13%	65.13%	+0.00%
github.com/smartcontractkit/chainlink-ccv/cmd	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/common	50.74%	50.74%	+0.00%
github.com/smartcontractkit/chainlink-ccv/executor	45.74%	45.74%	+0.00%
github.com/smartcontractkit/chainlink-ccv/indexer	37.50%	37.46%	-0.04%
github.com/smartcontractkit/chainlink-ccv/integration	47.68%	47.68%	+0.00%
github.com/smartcontractkit/chainlink-ccv/pkg	100.00%	100.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/pricer	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/protocol	65.19%	65.19%	+0.00%
github.com/smartcontractkit/chainlink-ccv/verifier	32.55%	32.56%	+0.01%

[Copilot]

Pull request overview

Refactors verifier/executor metrics interfaces to better separate ownership and narrow dependencies, especially around curse-checker and finality-checker metrics.

Changes:

• Verifier: Introduces FinalityCheckerMetrics and embeds it (plus common.CurseCheckerMetrics) into MetricLabeler.
• Finality checker: Narrows dependency from MetricLabeler to FinalityCheckerMetrics.
• Shared verifier interfaces: Re-exports FinalityCheckerMetrics via verifier/pkg.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
verifier/pkg/vtypes/interfaces.go	Adds FinalityCheckerMetrics; updates MetricLabeler to embed finality + curse metrics interfaces.
verifier/pkg/sourcereader/finality_checker.go	Changes finality checker service dependency to FinalityCheckerMetrics.
verifier/pkg/interfaces.go	Re-exports FinalityCheckerMetrics for external consumers.
executor/interfaces.go	Updates executor MetricLabeler to embed ccvcommon.CurseCheckerMetrics and removes inlined curse methods.

Comments suppressed due to low confidence (1)

verifier/pkg/sourcereader/finality_checker.go:69

• NewFinalityViolationCheckerService accepts metrics but doesn't validate it. If a nil implementation is passed, later calls to SetVerifierFinalityViolated (including in reset() and on violation detection) will panic. Consider either rejecting nil metrics in the constructor (consistent with other deps) or defaulting to a no-op implementation when nil is provided.

func NewFinalityViolationCheckerService(
	sourceReader chainaccess.SourceReader,
	chainSelector protocol.ChainSelector,
	lggr logger.Logger,
	metrics verifier.FinalityCheckerMetrics,
) (*FinalityViolationCheckerService, error) {
	if sourceReader == nil {
		return nil, fmt.Errorf("sourceReader cannot be nil")
	}
	if lggr == nil {
		return nil, fmt.Errorf("logger cannot be nil")
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.