feat: MCMS Treasury helper contract for fees - #786
Open
JohnChangUK wants to merge 4 commits into
Open
Conversation
friedemannf
reviewed
Aug 28, 2026
Comment on lines
+134
to
+137
| -- | Cancel an unused authorization (e.g. after expiry or policy change). | ||
| choice WithdrawAuthorization : () | ||
| controller feeOwner | ||
| do pure () |
Member
There was a problem hiding this comment.
feeOwner == ccipOwner, right? In this case this would need an MCMSEntrypoint as well, in order to be able to call it via MCMS
Member
There was a problem hiding this comment.
Lets either update this or add another choice that anyone can call after the authorization has expired. Kind of like a cleanup function callable by anyone to not leave expired authorizations hanging around.
Collaborator
Author
There was a problem hiding this comment.
Done
- Added
FeeWithdrawalAuthorizationnow has a signedauthorizationIdand implementsMCMSReceiver, so MCMS can target and cancel a specific authorization throughWithdrawAuthorization - Added
CleanupExpiredAuthorization, which any disclosed submitter can exercise oncenow >= expiresAt
| sdk-version: 3.4.11 | ||
| name: ccip-fee-treasury | ||
| source: daml | ||
| version: 2.0.0 |
Member
There was a problem hiding this comment.
Lets start on 1.0.0, this also implicitly makes it clearer that this is separate from the other CCIP contracts
JohnChangUK
changed the title
JohnChangUK
force-pushed
the
feat/mcms-fee-treasury
branch
from
August 30, 2026 18:01
a9c9037 to
feafba8
Compare
JohnChangUK
marked this pull request as ready for review
August 30, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.