Skip to content

Parse crlEntryExtensions in CRLs - #1262

Merged
hslatman merged 1 commit into
smallstep:masterfrom
magnuswatn:parse_crl_entry_extensions
Aug 26, 2024
Merged

Parse crlEntryExtensions in CRLs#1262
hslatman merged 1 commit into
smallstep:masterfrom
magnuswatn:parse_crl_entry_extensions

Conversation

@magnuswatn

Copy link
Copy Markdown
Contributor

Not sure if this was an oversight, or done on purpose, but extensions in RevocationListEntries were not being parsed. Now they get parsed.

Before change:

❯ step crl inspect --insecure 'http://crl4.digicert.com/sha2-ev-server-g1.crl' | grep "Revoked Certificates:" -A 5
        Revoked Certificates:
            Serial Number: 2799225036922445944820450433099856353 (0x021B1C73250B47C4CE8F305E639B79E1)
                Revocation Date: 2023-08-23 10:43:00 +0000 UTC
            Serial Number: 14874532436251617487517665762619838282 (0x0B30BB11F55A7DF580DDC276AF324F4A)
                Revocation Date: 2023-11-23 12:19:17 +0000 UTC
            Serial Number: 21201432819745242598424189347483327802 (0x0FF33F57C756BC0BA8A6B78606179D3A)

After change:

❯ ./bin/step crl inspect --insecure 'http://crl4.digicert.com/sha2-ev-server-g1.crl' | grep "Revoked Certificates:" -A 5
        Revoked Certificates:
            Serial Number: 2799225036922445944820450433099856353 (0x021B1C73250B47C4CE8F305E639B79E1)
                Revocation Date: 2023-08-23 10:43:00 +0000 UTC
                CRL Entry Extensions:
                    X509v3 CRL Reason Code:
                        Key Compromise

@github-actions github-actions Bot added the needs triage Waiting for discussion / prioritization by team label Aug 25, 2024
@hslatman hslatman self-assigned this Aug 26, 2024
@hslatman hslatman added this to the v0.27.3 milestone Aug 26, 2024
@hslatman

Copy link
Copy Markdown
Member

Thank you, @magnuswatn! I believe this to be an oversight. Change looks good, so I'll merge it. Pinging @maraino so that he at least sees it too 🙂

@hslatman
hslatman merged commit 036917a into smallstep:master Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants