Skip to content

Fix Release URLs with new file name formats. - #1256

Merged
dopey merged 7 commits into
masterfrom
jdoss/Fix_release_URLs
Aug 15, 2024
Merged

Fix Release URLs with new file name formats.#1256
dopey merged 7 commits into
masterfrom
jdoss/Fix_release_URLs

Conversation

@jdoss

@jdoss jdoss commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

This PR fixes the links in the releases.

@jdoss
jdoss requested a review from dopey August 14, 2024 20:53
@github-actions github-actions Bot added the needs triage Waiting for discussion / prioritization by team label Aug 14, 2024
Comment thread .goreleaser.yml Outdated
Comment thread .goreleaser.yml Outdated
jdoss and others added 4 commits August 15, 2024 09:51
Co-authored-by: Max <mx.furman@gmail.com>
Co-authored-by: Max <mx.furman@gmail.com>
@dopey
dopey merged commit 01b22f4 into master Aug 15, 2024
@dopey
dopey deleted the jdoss/Fix_release_URLs branch August 15, 2024 19:23
@hslatman hslatman added this to the v0.27.3 milestone Aug 20, 2024
@dbagarozza

Copy link
Copy Markdown

short question.

Will the release urls remain as they are? That the url now contains the -1, the packageRelease variable. It wasnt like that before. :)

@jdoss

jdoss commented Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

Hey @dbagarozza we are slowly moving forward with releasing Yum and Apt repos and we are going to be following the conventional file name formats for RPM and Deb packages. We cannot guarantee we won't issue a release update that keeps the same version number but bumps the pacakgeRelease variable. I don't expect it to happen that often.

If you are automating this on your end I would set the version you are grabbing to the full version + release (0.27.4-1 in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants